Re: [PATCH] Allow --quiet option to git remote, particularly for `git remote update`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alex Vandiver <alex@xxxxxxxxx> writes:

> Signed-off-by: Alex Vandiver <alex@xxxxxxxxx>

Sounds good as it makes the behaviour consistent with the underlying "git
fetch".

> ...
>  	"git remote prune [-n | --dry-run] <name>",
> -	"git remote [-v | --verbose] update [-p | --prune] [group | remote]",
> +	"git remote [-v | --verbose] [-q | --quiet] update [-p | --prune] [group]",

We say "<name>" everywhere else except for "update" we call the parameter
"group" or "remote" using different typography.  It is not the fault of
your patch, but has been this way since 1918278 (Allow git-remote to
update named groups of remotes, 2007-02-20).

Three issues to consider:

 - shouldn't we use the same typography, i.e. <group>?

 - should we say <name> _if_ we are not going to say <group>|<remote>?

 - should we keep it as <group>|<remote> to make it clear that only this
   subcommand allows the group nickname?

The first two are easy and I expect the answers to be both yes.  The third
one needs some studying and further thought.

 - is "remote update" the only one that takes group nickname?

 - should "remote update" the only one? e.g. does "remote prune" also
   take group? if not, shouldn't it?

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]