"James P. Howard, II" <jh@xxxxxxxxxxxxxx> writes: > This patch creates commit.infodisplay which causes git commit to > display the status information on the standard output rather > than in the temporary file for the commit message. By doing > this, it becomes feasible to set core.editor for commit messages > to be a line editor, e.g. ex or ed. Two points and a half: - Why does info_display need to be visible to everybody else by being in cache.h and environment.c? Shouldn't its scope be similar to that of template_file, that is static to builtin-commit.c? - A configuration variable that does not allow the users to override from the command line is a no-no. We usually do command line option first and then (or at the same time) configuration variable as a typesaver. - While the amount of change necessary for this change doesn't look too bad, is it really worth it? What is wrong with "1,$p" while using ed as your editor? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html