On Fri, Dec 04, 2009 at 02:58:42PM +0800, Tay Ray Chuan wrote:
> - if (!quiet || push_had_errors(remote_refs))
> - print_push_status(transport->url, remote_refs,
> - verbose | porcelain, porcelain,
> - nonfastforward);
> + if (!quiet)
> + if (push_had_errors(remote_refs)) {
> + ret = -1;
> + print_push_status(transport->url, remote_refs,
> + verbose | porcelain, porcelain,
> + nonfastforward);
> + }
Er, this doesn't seem right. It will no longer print anything under
non-quiet mode unless there are errors, and it will only set a return
value in non-quiet mode.
I think you want:
if (push_had_errors(remote_refs)) {
ret = -1;
if (!quiet)
print_push_status(...)
}
else if (!quiet)
print_push_status(...)
Actually, it may simply be more readable by storing the error result:
int err = push_had_errors(remote_refs);
if (err)
ret = -1;
if (!quiet || err)
print_push_status(...);
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html