On Wed, Dec 02, 2009 at 11:38:05AM -0800, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> - We should honor GIT_AUTHOR_DATE if --reset-author is given.
This is already a situation, as far as I see.
> - I _think_ we should ignore GIT_AUTHOR_DATE if --reset-author is not
> given, as --amend/-c/-C is stronger for being command line options than
> an environment variable.
We already ignore GIT_AUTHOR_DATE if --reset-author is not given, also
when I change it like this:
diff --git a/builtin-commit.c b/builtin-commit.c
index e93a647..7234c7d 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -397,7 +397,8 @@ static void determine_author_info(void)
name = xstrndup(a + 8, lb - (a + 8));
email = xstrndup(lb + 2, rb - (lb + 2));
- date = xstrndup(rb + 2, eol - (rb + 2));
+ if (!date)
+ date = xstrndup(rb + 2, eol - (rb + 2));
}
if (force_author) {
tests 27, 33, 38 and 39 fail in t7501-commit.sh.
Attachment:
pgpJskV9vS5Or.pgp
Description: PGP signature