On Monday 30 November 2009, Brandon Casey wrote: > Jeff King wrote: > > On Mon, Nov 30, 2009 at 12:07:40PM -0600, Brandon Casey wrote: > >> ps. There's something eerily familiar about this patch. > > > > Hmmm. Yes, I didn't search before writing it, but you probably mean: > > > > http://article.gmane.org/gmane.comp.version-control.git/127172 > > > :) yeah, that was it, nbd. Oops. I got Brandon's patches in my local tree, but I never got around to resend the series until Sverre picked up and refactored it. Sorry for the screwup. > > But that is missing the NO-PYTHON bit in GIT-BUILD-OPTIONS (did you > > forget it there, or was it part of some other patch that also didn't > > get applied?). > > It was 1/2 of that series. Indeed. > > Also, I am tempted to move the GIT-BUILD-OPTIONS invocation _up_. It > > is about reading config and should probably come before we start doing > > _anything_. > > > > So maybe this instead: > > <snip the patch> > > Looks fine to me. As with Brandon's original patch, this is of course Acked-by: Johan Herland <johan@xxxxxxxxxxx> > No strong opinion on whether the BUILD-OPTIONS thing should be > at the beginning of the script, or in the place where you placed > it. Me neither. ...Johan -- Johan Herland, <johan@xxxxxxxxxxx> www.herland.net -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html