On Mon, Nov 30, 2009 at 08:55:51AM +0100, Sverre Rabbelier wrote: > > This feels a little funny for NO_PYTHON to mean "no remote helpers at > > all". But that is the way the Makefile is set up, since we seem to have > > only python helpers. > > I don't understand what you mean? Do you mean NO_PYTHON implies "no > remote helpers at all", or "not having any remote helpers" implies > NO_PYTHON? Either way, I'm not sure how to set it up differently, not > having that much Makefile foo myself, so maybe Johan and Daniel could > comment? I mean, I would think that the "git_remote_helpers" directory contained remote helpers of all sorts, not just the python ones. Right now we _only_ have python ones. So checking for NO_PYTHON in test-lib.sh before looking at git_remote_helpers makes sense. But I am concerned that assumption will be broken silently in the future if non-python helpers are added to git_remote_helpers. It is probably not worth caring about too much, though. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html