Alex Chiang wrote:
Instead of passing all the various smtp* args to __send_message
individually, let's just pass the options list instead.
Looks good.
+ if (smtppassword and not smtpuser):
+ raise CmdException, 'SMTP password supplied, username needed'
+ if (smtpusetls and not smtpuser):
+ raise CmdException, 'SMTP over TLS requested, username needed'
Python style nit: Use "raise Exception('message')" in new code. (And
yes, I know you just moved these lines around.)
--
Karl Wiberg, kha@xxxxxxxxxxx
subrabbit.wordpress.com
www.treskal.com/kalle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html