Re: [RFC/PATCH] gitweb: Make linking to actions requiring JavaScript a feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> Would turning
>
>   "blame"
>
> link ito pair of links
>
>   "blame (incremental)"
>
> be a good solution?  I'm trying to come up with good naming for extra link
> to 'blame_incremental' action...

I had to step back a bit and ask myself what we are trying to achieve
here.  When the current blame and incremental one are both working
perfectly and well, will there be a reason for the end users to choose
between them when they click?

My answer is no.  If the incremental one gives nicer user experience in
all cases, it will be shown without the non-incremental one; if the
incremental one makes the server or network load too heavy, a site owner
may decide to show only the non-incremental one.

That makes my addLinks suggestion a change that would help _only_ while we
are working kinks out of the incremental one.

Let's not waste too much effort doing that.  Sorry for suggesting.

Letting the site owner choose if the site wants to set the "incremental if
possible" boolean would be more than adequate, I think.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]