Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx> writes:
> * Should I rename wt-status.c's color() into something more unique when
> I export it?
Is it an option to instead move short_unmerged(), short_status() and
friends to wt-status.c from builtin-commit.c? It's been quite a while
since I worked on the code, so I don't recall why it needs such cross
references at low level between two files.
> * Is there any policy regarding use of putchar/puts vs. printf?
J6t addressed it. You have mixture of putchar(' ') and printf(" ") which
looks somewhat funny ;-)
> * The way it is done now I "color" a space, otherwise one would need to
> break down the print statements even more. Since we always color the
> foreground only it is no problem, is it?
Some people do configure to use "reverse". For example, I have:
[diff.color]
old = red reverse
whitespace = blue reverse
[status.color]
updated = green
changed = red
untracked = blue reverse
The output should be consistent between long and short format (I do not
offhand recall what we do for the long format, though).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html