On Wed, środa 25. listopada 2009 22:39, Junio C Hamano napisał:
> Jakub Narebski <jnareb@xxxxxxxxx> writes:
>
> > It was 'Unspecified error.' shown in xhr watch. Accessing xhr.status
> > causes an error.
>
> As to the topic, it does not seem to break _existing_ features; if that is
> not the case, please let me know.
With the single exception of "Create links leading to 'blame_incremental'
using JavaScript" all commits are about opt-in features: either need to
be enabled in gitweb config ('timed' feature), or you need to handcraft
URL ('blame_incremental' as action parameter).
The commit that makes 'blame' links to use 'blame_incremental' view if
JavaScript is enabled might break 'blame' view for IE8 users.
> Otherwise I'm inclined to merge the entire series to 'master' by 1.6.6-rc1.
>
> 6821dee gitweb.js: fix padLeftStr() and its usage
> 6aa2de5 gitweb.js: Harden setting blamed commit info in incremental blame
> e42a05f gitweb.js: fix null object exception in initials calculation
> 63267de gitweb: Minify gitweb.js if JSMIN is defined
> c4ccf61 gitweb: Create links leading to 'blame_incremental' using JavaScript
> e206d62 gitweb: Colorize 'blame_incremental' view during processing
> 4af819d gitweb: Incremental blame (using JavaScript)
> aa7dd05 gitweb: Add optional "time to generate page" info in footer
> -aef3768 gitweb: Use light/dark for class names also in 'blame' view
>
> and treat it as a new feature with known breakages, to give it wider
> audience. That way you will hopefully get more people who are willing to
> help debug/fix things for you.
Perhaps then it would be better to put commit that creates links to
'blame_incremental' action last, and have it in 'next' and not in master?
Below there is request-pull with reordered series, unless you want me
to resend this series as a set of patches, as reply to this email.
-- >8 --
The following changes since commit b073b7a990deb1cb3425db45642fa18c8b3cb65c:
Benjamin Kramer (1):
Explicitly truncate bswap operand to uint32_t
are available in the git repository at:
git://repo.or.cz/git/jnareb-git.git gitweb/web
7bc7e38 gitweb: Create links leading to 'blame_incremental' using JavaScript
aa1ff3d gitweb.js: Harden setting blamed commit info in incremental blame
da51a3c gitweb.js: fix padLeftStr() and its usage
a253a2c gitweb.js: fix null object exception in initials calculation
fbebd29 gitweb: Minify gitweb.js if JSMIN is defined
8ba6343 gitweb: Colorize 'blame_incremental' view during processing
0e14278 gitweb: Incremental blame (using JavaScript)
c4c6645 gitweb: Add optional "time to generate page" info in foot
Jakub Narebski (6):
gitweb: Add optional "time to generate page" info in footer
gitweb: Incremental blame (using JavaScript)
gitweb: Colorize 'blame_incremental' view during processing
gitweb: Minify gitweb.js if JSMIN is defined
gitweb.js: Harden setting blamed commit info in incremental blame
gitweb: Create links leading to 'blame_incremental' using JavaScript
Stephen Boyd (2):
gitweb.js: fix null object exception in initials calculation
gitweb.js: fix padLeftStr() and its usage
Makefile | 26 ++-
git-instaweb.sh | 7 +
gitweb/README | 5 +
gitweb/gitweb.css | 25 ++
gitweb/gitweb.js | 870 ++++++++++++++++++++++++++++++++++++++++++++++++++++
gitweb/gitweb.perl | 311 ++++++++++++++-----
6 files changed, 1157 insertions(+), 87 deletions(-)
create mode 100644 gitweb/gitweb.js
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html