Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > Maybe I should wait until somebody adds the tests to --envelope-sender > before pushing this patch. You can say that if you want to be difficult to work with, or you can be that somebody yourself and make a difference. Let me show you that we can be constructive for a change ;-) How about something trivial like this? -- >8 -- Subject: [PATCH] t9001: test --envelope-sender option of send-email Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> --- t/t9001-send-email.sh | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 84a7f03..004e81c 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -95,6 +95,23 @@ test_expect_success \ 'Verify commandline' \ 'test_cmp expected commandline1' +test_expect_success 'Send patches with --envelope-sender' ' + clean_fake_sendmail && + git send-email --envelope-sender="Patch Contributer <patch@xxxxxxxxxxx>" --suppress-cc=sob --from="Example <nobody@xxxxxxxxxxx>" --to=nobody@xxxxxxxxxxx --smtp-server="$(pwd)/fake.sendmail" $patches 2>errors +' + +cat >expected <<\EOF +!patch@xxxxxxxxxxx! +!-i! +!nobody@xxxxxxxxxxx! +!author@xxxxxxxxxxx! +!one@xxxxxxxxxxx! +!two@xxxxxxxxxxx! +EOF +test_expect_success \ + 'Verify commandline' \ + 'test_cmp expected commandline1' + cat >expected-show-all-headers <<\EOF 0001-Second.patch (mbox) Adding cc: A <author@xxxxxxxxxxx> from line 'From: A <author@xxxxxxxxxxx>' -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html