On Sat, Nov 21, 2009 at 9:59 PM, Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote: > On Sat, Nov 21, 2009 at 9:36 PM, Jeff King <peff@xxxxxxxx> wrote: >> --envelope-from is IMHO confusingly similar to >> --envelope-sender. Maybe --use-from-in-envelope would be a better name? > > Ok. I don't have any opinion on the name. I thought a bit more about this, and in the end what we really want is to add the sender envelope. The most typical case would be to use the 'from' address, but we should be able to override it (we do both by using --envelope-sender). So here are other options. a) --add-envelope: add the sender envelope, by default it would be the 'from' address, but could be overridden by --envelope-sender. b) --envelope-sender="" or "auto": this would require minimal changes but looks a bit strange. Any thoughts? -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html