Junio C Hamano wrote: > David Aguilar <davvid@xxxxxxxxx> writes: > >> i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5493) compiler >> (and probably others) mistakenly thinks variable 'right' is used >> before assigned. Work it around by giving it a fake initialization. > > We see the same "fake initialization" of 'left' on the same line. By > initializing it to NULL, you are hinting that initializing 'right' to > NULL actually means something. Why is the compiler not complaining about the fake initalization? For initialization a value is used that is not initialized. At least a static analyzer complains: "submodule.c", line 41: The variable `left' is used before its initialization Christoph -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html