On Wed, Nov 18, 2009 at 12:30:36PM +0100, Bert Wesarg wrote: > Insired by the coloring of quilt. > > Introduce a separate color for the hunk comment part, i.e. the current > function. Whitespace between hunk header and hunk comment is now > printed as plain. > > The current default is magenta. But I'm not settled on this. My > favorite would be bold yellow. I don't see any reason not to add this, as it is simply introducing one extra knob to tweak for people who care. However, after some experimentation, I found that I don't personally really like it. I ended up wanting it set to the same color as the hunk header. I wonder how hard it would be to make it backwards-compatible; that is, to inherit the color value of the hunk header (be it the original or one set by the user) unless the func color is set by the user. But maybe that is over-engineering. It is not like we are breaking scripts, and it is not that hard for people to see the new behavior and then tweak their config if they don't like it. -Peff PS I almost complained about your default of "magenta" as the same as the meta color before I remembered that magenta meta is a personal setting I use. Personally I find the bold meta color to be distractingly ugly. Blaming it, the default seems to come from Linus, who even in his commit message (50f575f) seems to indicate that it is somewhat arbitrary (mostly just dropping the purple from the bold purple). I'm not sure what is the best way to arrive at a default color for something like this. Arguing about it really is almost the definition of bikeshedding. Maybe next year's git survey should contain a special section on colors, and majority should rule. :) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html