Re: [PATCH] http-backend: Fix bad treatment of uintmax_t in Content-Length

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tarmigan <tarmigan+git@xxxxxxxxx> writes:

> On Wed, Nov 11, 2009 at 8:42 PM, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote:
>> Our Content-Length needs to report an off_t, which could be larger
>> precision than size_t on this system (e.g. 32 bit binary built with
>> 64 bit large file support).
>>
>> We also shouldn't be passing a size_t parameter to printf when
>> we've used PRIuMAX as the format specifier.
>>
>> Fix both issues by using uintmax_t for the hdr_int() routine,
>> allowing strbuf's size_t to automatically upcast, and off_t to
>> always fit.
>>
>> Also fixed the copy loop we use inside of send_local_file(), we never
>> actually updated the size variable so we might as well not use it.
>>
>> Reported-by: Tarmigan <tarmigan+git@xxxxxxxxx>
>
> Tested-by: Tarmigan <tarmigan+git@xxxxxxxxx>

Thanks; care to spell your name in full (as if you are publishing say a
scientific paper)?  I am guessing that the other Tarmigan with full name
who posted a few patches is the same person as you.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]