--- Jakub Narebski <jnareb@xxxxxxxxx> wrote:
> Junio C Hamano wrote:
>
> > Luben Tuikov <ltuikov@xxxxxxxxx> writes:
> >
> >> 1) All entries on the left are blobs and clicking on them
> >> leads to blobs. No more diff or blob depending on what
> >> happened (modified or mode changed) to the file -- this goes
> >> to the right, in the "link" column.
> >>
> >> 2) Remove redundant "blob" from the link column on the right.
> >> This can now be had by clicking on the entry itself.
> >>
> >> This reduces and simplifies the code.
> >>
> >> Signed-off-by: Luben Tuikov <ltuikov@xxxxxxxxx>
> >
> > We lost blobdiff from commitdiff page with this patch, which I
> > think it probably is a good change. We can say "when we display
> > a pathname you can click it to get the blob or tree".
>
> In my opinion it is a bad change. We now have "patch" inner-link
> to anchor in commitdiff view, but it's equivalent in commit view
> i.e. diff aka blobdiff vanished.
All which can be easily had.
Luben
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html