Re: commit log encoding [Was: [PATCH 1/2] tree-wide: fix typos "offest" -> "offset"]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 11, 2009 at 01:19:32PM +0100, Jiri Kosina wrote:
> On Wed, 11 Nov 2009, Uwe Kleine-König wrote:
> 
> > > Thanks for noticing, I had a bug in my git charset config for quite some 
> > > time. Fixed it now.
> > Now my name is latin1 encoded.  It should be utf-8, doesn't it?
> 
> It's not latin1, it's iso-8859-2
For my name it makes no difference.

>                                   which is what I use on my terminals.
> And git can handle that fine too (it stores the encoding together with the 
> commit).
Ah, OK, that's news to me, but you're right.  I have here:

	~/gsrc/linux-2.6$ git cat-file commit 30ff0743f88a70f52a4de5ea5bcb1fd29bcfab2d
	tree 6121d35bb2606878be636e897fa77cd51804d724
	parent 916b7c73db593510d5c38706be2f2888981747ee
	author Uwe Kleine-K�nig <u.kleine-koenig@xxxxxxxxxxxxxx> 1256757064 +0100
	committer Jiri Kosina <jkosina@xxxxxxx> 1257780224 +0100
	encoding ISO-8859-2

	tree-wide: fix typos "couter" -> "counter"

	This patch was generated by

		git grep -E -i -l 'couter' | xargs -r perl -p -i -e 's/couter/counter/'

	Signed-off-by: Uwe Kleine-K�nig <u.kleine-koenig@xxxxxxxxxxxxxx>
	Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>

So the remaining question is: Does the encoding specified in the
encoding "header" also apply to the other headers?

If yes[1] then there's a bug in git-shortlog

	~/gsrc/linux-2.6$ git shortlog linus/master..trivial/for-next | grep Uwe
	Uwe Kleine-K�nig (5):

(with linus/master = 799dd75b1a8380a967c929a4551895788c374b31,
trivial/for-next = 4030ec040a0e21fe9953da70eaa59ee7b4f2297b).
 
Best regards
Uwe

[1] git log linus/master..trivial/for-next looks OK, so I suspect it
does apply.

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]