On Dienstag, 10. November 2009, Junio C Hamano wrote: > Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > > Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> > > --- > > Why do you have inclusion of "exec_cmd.h" in [19/24]? As far as I can > tell, nothing you do in that patch depends on it. > > According to c6dfb39 (remote-curl: add missing initialization of > argv0_path, 2009-10-13), this patch is necessary (and you must include > "exec_cmd.h") on MinGW, regardless of the "give help upon -h" topic. > > I think this should be ejected from your series go directly to 'maint', or > am I mistaken? You are right. This command (in bash): comm <(git grepc -l main\( *.c) <(git grepc -l extract_argv0 *.c) shows programs in the 1st column that have main(), but do not call git_extract_argv0_path. One remaining candidate is show-index.c, but its only call-out is sha1_to_hex(), which doesn't use any other services. http-fetch.c is the only file that needs this patch. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html