Re: [PATCH v3 08/12] Allow helper to map private ref names into normal names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 6 Nov 2009, Sverre Rabbelier wrote:

> From: Daniel Barkalow <barkalow@xxxxxxxxxxxx>
> 
> This allows a helper to say that, when it handles "import
> refs/heads/topic", the script it outputs will actually write to
> refs/svn/origin/branches/topic; therefore, transport-helper should
> read it from the latter location after git-fast-import completes.
> ---
> 
> 	New in this series.
> 	Daniel, you did not include a S-o-b, I assume because you
> 	mean to add documentation?

I wasn't terribly convinced I'd actually implemented it correctly, since I 
couldn't test it essentially at all; I was just going for something that 
gave the right idea. 

At the very least, it needs documentation and memory leaks fixed (the 
refspec strings read from the helper, and the refspec structs and array on 
freeing the helper data).

Is this actually working with your helper? Occasionally I write code that 
just works without any testing, but I don't usually expect it. :)

	-Daniel
*This .sig left intentionally blank*
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]