Re: [PATCH] MSVC: Windows-native implementation for subset of Pthreads API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 5 Nov 2009, Andrzej K. Haczewski wrote:

> @@ -1638,6 +1657,8 @@ static void ll_find_deltas(struct object_entry **list, unsigned list_size,
>  				delta_search_threads);
>  	p = xcalloc(delta_search_threads, sizeof(*p));
>  
> +	init_threaded_search();

Careful.  At the beginning of the function you'll find:

        if (delta_search_threads <= 1) {
                find_deltas(list, &list_size, window, depth, processed);
                return;
        }

That is, if we have thread support compiled in but we're told to use 
only one thread, then the bulk of the work splitting is bypassed 
entirely.  Inside find_deltas() there will still be pthread_mutex_lock() 
and pthread_mutex_unlock() calls even if no threads are spawned.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]