Re: [PATCH] MSVC: Windows-native implementation for subset of Pthreads API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 4 Nov 2009, Andrzej K. Haczewski wrote:

> 2009/11/4 Nicolas Pitre <nico@xxxxxxxxxxx>:
> > On Wed, 4 Nov 2009, Andrzej K. Haczewski wrote:
> >
> >> +     NO_STATIC_PTHREADS_INIT = YesPlease
> >
> > Let's not go that route please.  If Windows can't get away without
> > runtime initializations then let's use them on all platforms.  There is
> > no gain in exploding the code path combinations here wrt testing
> > coverage.
> >
> 
> I don't like that approach either, but I was frighten of Junio being
> anal about static inits ;).

I think the alternative is much worse than loosing those static inits.

> Let's make it clear: has anyone have any objections that I add
> explicit initialization of mutexes and condition variables for POSIX
> also?

Please do it and if anyone finds a problem with it then we'll start from 
there.


Nicolas

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]