Excerpts from Junio C Hamano's message of Wed Nov 04 14:36:32 -0500 2009: > I am a bit puzzled about the "warning" logic. Is this because you expect > variables we typically give YesPlease/NoThanks as their values will not be > handled with this new PARSE_WITH_SET_MAKE_VAR() macro? No, this is because it's perfectly acceptable, in my opinion for a user to say: --with-pager=no or --with-editor=yes Neither of those are smart things to do, but they're not necessarily wrong, either. I'm open to bailing on error for these, but I thought leaving these as unvalidated, but with a warning, was more flexible...if say a user wanted to have a pager called 'no' or something. For the variables that are accepting YesPlease/NoThanks, I think it's more suitable to use the standard autoconf header/function/library detection as it stands now. This macro is more for 'oddball' variables like DEFAULT_PAGER, DEFAULT_EDITOR, etc that aren't necessarily easily detectable. In some cases, even if it were detectable, the detection might not be right. Thanks -Ben -- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302 GPG Key Id: 8E89F6D2; Key Server: pgp.mit.edu Contact me to arrange for a CAcert assurance meeting.
Attachment:
signature.asc
Description: PGP signature