Re: [PATCH bg/format-patch-p-noop] log-tree: always add --- marker when options are patch and a stat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2009/11/4 Junio C Hamano <gitster@xxxxxxxxx>:

> In an ideal world, I would probably say:
>
>  * format-patch should have three-dash after the commit message, no matter
>   what format the patch is asked for, and it always will give patch text.

I agree.

>  * format-patch -p should be reinstated as a way to ask for "just patch
>   text, no diffstat".  Introducing a new option --no-stat _in addition_
>   to improve the UI is Ok.

Since -p has been broken for 14 months, is really necessary to reinstate
it? (Or has the breakage not been reported because the people who care
still use a git version older than 14 months?)

Why not just add a new --no-stat option?

>  * format-patch -U<n> should not be mistaken as a request to suppress
>   diffstat; what 68daa64 _tried_ to do was worthy.

I agree.

/Björn

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]