Re: [PATCH 1/1] MSVC: port pthread code to native Windows threads

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- Original Message -----
From: Johannes Schindelin
Date: 11/3/2009 4:38 PM
  #ifdef THREADED_DELTA_SEARCH
-#include "thread-utils.h"
-#include<pthread.h>
+# include "thread-utils.h"
+# ifndef _WIN32
+#  include<pthread.h>
+# else
+#  include<winthread.h>
+# endif
  #endif

It is unlikely that an #ifdef "contamination" of this extent will go
through easily, but I have a suggestion that may make your patch both
easier to read and more likely to be accepted into git.git: Try to wrap
the win32 calls into pthread-compatible function signatures.  Then you can
add a compat/win32/pthread.h and not even touch core files of git.git at
all.
Pardon my ignorance, but is there a reason to not use Pthreads for Win32? http://sourceware.org/pthreads-win32/

Josh
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]