On Tue, Sep 22, 2009 at 02:39, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx> writes: >> if {$revs eq {}} { >> set revs HEAD >> + } elseif {$revs eq "--all"} { >> + return $revs >> } > > That looks like an ugly hack (aka sweeping the issue under the rug). > And it is a race condition. By the time git log has got --all list of references it may look completely different to what gitk has. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html