Re: [PATCH 2/4] Makefile: merge two Cygwin configuration sections into one

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Sixt <j.sixt@xxxxxxxxxxxxx> writes:

> Ramsay Jones schrieb:
>> diff --git a/Makefile b/Makefile
>> index fea237b..8e1cfc5 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -782,6 +782,8 @@ ifeq ($(uname_O),Cygwin)
>>  	NO_MMAP = YesPlease
>>  	NO_IPV6 = YesPlease
>>  	X = .exe
>> +	COMPAT_OBJS += compat/cygwin.o
>> +	UNRELIABLE_FSTAT = UnfortunatelyYes
>>  endif
>>  ifeq ($(uname_S),FreeBSD)
>>  	NEEDS_LIBICONV = YesPlease
>> @@ -891,10 +893,6 @@ ifeq ($(uname_S),HP-UX)
>>  	NO_SYS_SELECT_H = YesPlease
>>  	SNPRINTF_RETURNS_BOGUS = YesPlease
>>  endif
>> -ifneq (,$(findstring CYGWIN,$(uname_S)))
>> -	COMPAT_OBJS += compat/cygwin.o
>> -	UNRELIABLE_FSTAT = UnfortunatelyYes
>> -endif
>>  ifdef MSVC
>>  	GIT_VERSION := $(GIT_VERSION).MSVC
>>  	pathsep = ;
>
> I think this an obviously good change even outside this series.

Thanks; I think this one makes sense.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]