Re: [PATCH] commit -c/-C/--amend: acquire authorship and restamp time with --claim

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2009/11/1 Junio C Hamano <gitster@xxxxxxxxx>:
> Erick Mattos <erick.mattos@xxxxxxxxx> writes:
>
>>>    % git commit --claim --author='Erick Mattos <eric@mattos>' -C HEAD
>>>
>>> Should you detect an error?  Does your code do so?  Do you have a test
>>> that catches this error?
>>
>> It works as intended.  Both together.
>
> That does not make any sense.  If you are saying this is yours and it is
> his at the same time, there can be no sane way to work "as intended", no?.

I am adding a new option not changing the option --author already in
git.  So it does work together.

>>>> +     git commit -c HEAD <<EOF
>>>> +     "Changed"
>>>> +     EOF &&
>>>
>>> What editor is reading this "Changed"?
>>
>> Nobody cares...  Just a text to change the file.
>
> I actually care.  Who uses that Changed string, and where does it end up
> with?  At the end of the log message?  At the beginning?  What "file"?
>

I didn't get it.  -c option does not accept -m option and starts an
editor to change the message.  The text "Changed is just a forced
message.  I can not use an editor in interactive mode in a script...
What I am losing here??
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]