On Thu, 29 Oct 2009, Sverre Rabbelier wrote: > From: Daniel Barkalow <barkalow@xxxxxxxxxxxx> > > For fetch and ls-remote, which use the first url of a remote, have > transport_get() determine this by passing a remote and passing NULL > for the url. For push, which uses every url of a remote, use each url > in turn if there are any, and use NULL if there are none. > > This will allow the transport code to do something different if the > location is not specified with a url. > > Also, have the message for a fetch say "foreign" if there is no url. > > Signed-off-by: Daniel Barkalow <barkalow@xxxxxxxxxxxx> > Signed-off-by: Sverre Rabbelier <srabbelier@xxxxxxxxx> > --- > > I rebased this on master and had major conflicts with the > recent 'advice' series, Daniel, please have a look at this to > see whether it is sane at all. Yup, this is right. Perhaps I should try to get the refactor in builtin-push to use push_with_options() without any behavior change into master ahead of the rest of this series, to avoid having to deal with this sort of conflict every time someone touches this section of code, which has happened several times recently now. Anyway, you correctly understood the intended change here. -Daniel *This .sig left intentionally blank* -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html