Junio C Hamano <gitster@xxxxxxxxx> wrote: > > The NUL assignment isn't about safe_read(), its about making the > > block of 4 bytes read a proper C-style string so we can safely pass > > it down into the snprintf that is within die(). > > I knew and understood all of what you just said. static linelen[] is not > about stack allocation. It's about letting the compiler initialize it to > five NULs so that you do not have to assign NUL to its fifth place before > you die. This removes one added line from your patch. Thanks, I get it now. Patch amended. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html