The two patches look ok to me (not withstanding the comments already made about the test and possible future changes required). I did make a few small tweaks to use | instead of / as the sed substitution separator (since we're presumably working with full paths). The substitution was also extended into the .sh scripts (git-am, explicitly). Jonathan Nieder (1): Provide a build time default-editor setting Junio C Hamano (1): Provide a build time default-pager setting Makefile | 19 +++++++++++++++++++ editor.c | 2 +- git-add--interactive.perl | 3 ++- git-am.sh | 2 +- git-sh-setup.sh | 6 ++++-- git-svn.perl | 8 +++++--- pager.c | 2 +- t/Makefile | 2 ++ t/t7005-editor.sh | 29 ++++++++++++++++++++++------- 9 files changed, 57 insertions(+), 16 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html