The current logic prevents both 'remote.url' and 'remote.vcs' from being set, while that might be useful. Signed-off-by: Sverre Rabbelier <srabbelier@xxxxxxxxx> --- This way I can do: remote.hgremote.url = /path/to/hg/repo remote.hgremote.vcs = hg As well as: remote.hgremote.url = hg::/path/to/hg/repo remote.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/remote.c b/remote.c index f0441c4..29365de 100644 --- a/remote.c +++ b/remote.c @@ -50,7 +50,7 @@ static char buffer[BUF_SIZE]; static int valid_remote(const struct remote *remote) { - return !remote->url != !remote->foreign_vcs; + return (!!remote->url) || (!!remote->foreign_vcs); } static const char *alias_url(const char *url) -- 1.6.5.2.291.gf76a3 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html