Re: [PATCH] Fix memory leak in transport-helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 27, 2009 at 01:37:19PM -0400, Daniel Barkalow wrote:

> > Why did you not leech the transport->data = NULL; part from Peff/Sverre's 
> > patch?
> 
> Because this code is only called just before transport itself is freed by 
> the caller, and, in general, a transport with these methods is invalid 
> without a valid transport->data. I expect that's also why Peff called it a 
> hack not appropriate for actual application.

More or less. I called it a hack because I didn't even look far enough
to know whether or not that was the case. I was just trying to get it to
stop segfaulting so Sverre could continue his work.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]