Re: [ANNOUNCE] Stacked Git 0.15

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2009-10-26 10:32:07 +0000, Catalin Marinas wrote:

> The problem was a bit more complicated than this. Some files are
> generated by the Makefile rather than setup.py so using the latter
> directly fails to build anything.
>
> So it's time for 0.15.1 this week with the fix below (in my
> "proposed" branch). I cc'ed Karl as well in case he has time to have
> a quick look.

I don't have any objections, except ...

> diff --git a/Makefile b/Makefile
> index 0fa5c6a..5f88f7d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -4,20 +4,10 @@ PYTHON	?= python
> 
>  TEST_PATCHES ?= ..
> 
> -all: build
> +all:
>  	$(PYTHON) setup.py build
> 
> -build: stgit/commands/cmdlist.py stgit-completion.bash
> -
> -ALL_PY = $(shell find stgit -name '*.py')
> -
> -stgit/commands/cmdlist.py: $(ALL_PY)
> -	$(PYTHON) stg-build --py-cmd-list > $@
> -
> -stgit-completion.bash: $(ALL_PY)
> -	$(PYTHON) stg-build --bash-completion > $@
> -
> -install: build
> +install:
>  	$(PYTHON) setup.py install --prefix=$(prefix) --root=$(DESTDIR) --force
> 
>  doc:
> @@ -29,10 +19,10 @@ install-doc:
>  install-html:
>  	$(MAKE) -C Documentation install-html
> 
> -test: build
> +test:
>  	cd t && $(MAKE) all

... don't we need to run "setup.py build" here in order to not change
the behavior?

-- 
Karl Wiberg, kha@xxxxxxxxxxx
    www.treskal.com/kalle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]