Remove mention of packed refs from the test description, and expect success. The dumb http push mechanism used to learn about the refs on the remote repository by recursing through the /refs directory in the repository. This meant that it was unaware of packed refs, since it did not read /packed-refs. Thus the push failed, as no remote refs were found. But after c6aa27e (Move WebDAV HTTP push under remote-curl, Wed Oct 14), the dumb http mechanism additionally learns about the refs through /info/refs (via remote-curl.c::get_refs), so it is aware of packed refs, even though it still doesn't read /packed-refs (assuming /info/ refs is up-to-date). Thus the push now succeeds. Signed-off-by: Tay Ray Chuan <rctay89@xxxxxxxxx> --- t/t5540-http-push.sh | 12 +----------- 1 files changed, 1 insertions(+), 11 deletions(-) diff --git a/t/t5540-http-push.sh b/t/t5540-http-push.sh index f4a2cf6..c7b8a40 100755 --- a/t/t5540-http-push.sh +++ b/t/t5540-http-push.sh @@ -45,7 +45,7 @@ test_expect_success 'clone remote repository' ' git clone $HTTPD_URL/test_repo.git test_repo_clone ' -test_expect_failure 'push to remote repository with packed refs' ' +test_expect_success 'push to remote repository' ' cd "$ROOT_PATH"/test_repo_clone && : >path2 && git add path2 && @@ -57,16 +57,6 @@ test_expect_failure 'push to remote repository with packed refs' ' test $HEAD = $(git rev-parse --verify HEAD)) ' -test_expect_success ' push to remote repository with unpacked refs' ' - (cd "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git && - rm packed-refs && - git update-ref refs/heads/master \ - 0c973ae9bd51902a28466f3850b543fa66a6aaf4) && - git push && - (cd "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git && - test $HEAD = $(git rev-parse --verify HEAD)) -' - test_expect_success 'http-push fetches unpacked objects' ' cp -R "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git \ "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo_unpacked.git && -- 1.6.4.4 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html