Junio C Hamano <gitster@xxxxxxxxx> writes: > Sverre Rabbelier <srabbelier@xxxxxxxxx> writes: > > > This is my main concern, adding 'bash_completion' as a target to all: > > would be ok; why would 'make clean' break it? As long as you don't add > > "make -C contrib/completion clean' to the main clean target there's no > > problem? > > "make clean" should remove it, because it is a normal build product, > if you make your "make all" build completion scripts. > > The word _should_ is used in the RFC2119 sense: there may exist valid > reasons in particular circumstances to ignore a particular item, but the > full implications must be understood and carefully weighed before choosing > a different course. If we take similar approach to the way gitweb can be build to the bash completion script, which means building it via make contrib/completion/git-completion.bash (and not make this target part of "make all"), then there is, I think, no reason for "make clean" to remove it, isn't it? -- Jakub Narebski Poland ShadeHawk on #git -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html