On 14:25 Thu 28 Sep , Junio C Hamano wrote:
> Sasha Khapyorsky <sashak@xxxxxxxxxxxx> writes:
>
> > If GIT_CURL_FTP_NO_EPSV environment variable is defined, disable using
> > of EPSV ftp command (PASV will be used instead). This is helpful with
> > some "poor" ftp servers which doesn't support EPSV mode.
> >
> > Signed-off-by: Sasha Khapyorsky <sashak@xxxxxxxxxxxx>
> > ---
> > http.c | 3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/http.c b/http.c
> > index 6c1937b..a966e6d 100644
> > --- a/http.c
> > +++ b/http.c
> > @@ -196,6 +196,9 @@ #endif
> >
> > curl_easy_setopt(result, CURLOPT_USERAGENT, GIT_USER_AGENT);
> >
> > + if (getenv("GIT_CURL_FTP_NO_EPSV"))
> > + curl_easy_setopt(result, CURLOPT_FTP_USE_EPSV, 0);
> > +
> > return result;
> > }
> >
> > --
> > 1.4.2.1
>
> Care to match this with existing ones?
>
> $ git grep -e GIT_CURL -e GIT_SSL -e GIT_HTTP
>
> tells you how they are handled and documented. If you spot
> inconsistencies if any (e.g. some having config entry and some
> only environment -- I haven't checked), correcting them while
> you are at it might be a good thing as well.
Make sense. Will rework.
Sasha
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html