--- Junio C Hamano <junkio@xxxxxxx> wrote:
>
> Ouch, that was a sloppy planning and coding, and sloppier
> reviewing. Sorry.
>
> What is the right quoting there? Just quoting double-quotes?
I'm not sure. What undesired character could we have in $filename
of a snapshot? The commit ab41dfbfd4f message gives this
justification: "Just in case filename contains end of line character."
It looks like $filename is constructed by well defined strings:
basename($project), $hash and $suffix all of which should be ok.
I'd say we don't need quotemeta for $filename of snapshot.
Luben
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html