Re: [PATCH 1/3] diff --stat: allow custom diffstat output width.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, 26 Sep 2006, Junio C Hamano wrote:
>
> This adds two parameters to "diff --stat".
> 
>  . --stat-width=72 tells that the page should fit on 72-column output.
> 
>  . --stat-name-width=30 tells that the filename part is limited
>    to 30 columns.

Thinking some more about this, I have to say, I do hate the syntax.

It may be clear thanks to being verbose, but it's _hell_ to write.

It has the same problem the "--stat-with-patch" argument had: sure, it 
worked, but it was really really inconvenient, and just doing a 
combination of "--stat -p" is much nicer.

So how about just extending the existing "--stat" thing, and just making 
it do something like

	git diff --stat=72,30

instead (perhaps along with a config option to set the defaults to 
something else if we want to).

What do you think?

I'm just pretty sure I will never _ever_ bother to type 
--stat-name-width=30 in my life except right now to complain about it. I 
just can't see myself ever caring _that_ much. But "--stat=100" to see a 
wider stat, that I could see myself doing. Or "--stat=100,100" if I want 
to see long filenames too.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]