On Tue, Oct 20, 2009 at 09:18:29AM -0700, Junio C Hamano wrote: > Matt Kraai <kraai@xxxxxxxxx> writes: > > > Do not check whether PERL_PATH and SHELL_PATH are undefined before > > setting their default values. This prevents them from being set via > > environment variables. > > Is there an upside of "preventing them from getting set", by the way? Not that I know of. I originally thought that the checks were superfluous, but now I just believe they're inconsistent and confusing to people like me who think they understand Makefiles but don't. :) -- Matt Kraai http://ftbfs.org/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html