Hi, On Tue, 20 Oct 2009, Sebastian Schuberth wrote: > On Tue, Oct 20, 2009 at 09:04, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > >> When compiling with MSVC on x86-compatible, use an intrinsic for byte > >> swapping. In contrast to the GCC path, we do not prefer inline > >> assembly here as it is not supported for the x64 platform. > >> > >> Signed-off-by: Sebastian Schuberth <sschuberth@xxxxxxxxx> > > > > Unlike the other one this is not Acked by Marius, Dscho, or J6t; > > should I pick this up myself, or should I wait to be fed by one of > > msysgit people? > > Well, in fact I am one of the msysgit poeple, although I mostly worked > on the installer until now. In general, I like my patches to be > reviewed, but this one is rather uncritical, I guess. So it's up to you, > Junio, I'm perfectly OK with waiting for an ACK. Apart from the fact that I do not have MSVC (and I don't want it, either), there is another strong reason why I think Sebastian does not need ACKs or SOBs on MSVC patches: he has plenty of experience as a maintainer of a rather big (commercial) software that has to compile on Windows, MacOSX and several Unix-type OSes (and it is known that Sebastian is a Windows guy). So I would trust Sebastian's patches (at least when it comes to MSVC) without even reviewing them. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html