On Monday 19 October 2009 01:07:23 Junio C Hamano wrote: > That is Ok; the comment was not about stage vs add. > > > But beyond that, yes, you are right that removing a "+" line may have a > > different conceptual meaning to the user depending on the surrounding > > text. I wonder if such a "check-list" document really makes much sense, > > given that using "-e" at all means you need to understand the patch > > format and what makes sense (i.e., anybody who understands 'patch' > > knows that you can't just delete context lines and expect it to apply). > > Yeah, that is really what I wanted people who are in this discussion to > eventually realize ;-) Comment from the peanut gallery: I still think a quick summary checklist is useful even for a seasoned developer that is intimate with the 'patch' format, as it lets users know what git will do with your patch modifications. For example, when I first tried "add -e", my first thought was: "Awesome, but, I wonder if git will do the right thing if I modify the patch in THIS way ...". Fortunately, git did the right thing, but I wasn't really sure until I tried it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html