Hi, On Fri, 16 Oct 2009, Junio C Hamano wrote: > consumed = fn(sb, format, context); > - if (consumed) > + if ((ssize_t) consumed < 0) > + break; Would it not be much better to fix the signature of fn in a separate commit before this one? Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html