On Wed, Oct 14, 2009 at 12:11:09AM +0200, Björn Steinbrink wrote: > When we use -b <branch>, we may checkout something else than what the > remote's HEAD references, but we still used remote_head to supply the > new ref value to the post-checkout hook, which is wrong. > > So instead of using remote_head to find the value to be passed to the > post-checkout hook, we have to use our_head_points_at, which is always > correctly setup, even if -b is not used. > > This also fixes a segfault when "clone -b <branch>" is used with a > remote repo that doesn't have a valid HEAD, as in such a case > remote_head is NULL, but we still tried to access it. > > Reported-by: Devin Cofer <ranguvar@xxxxxxxxxxxx> > Signed-off-by: Björn Steinbrink <B.Steinbrink@xxxxxx> Acked-by: Jeff King <peff@xxxxxxxx> Thanks. When splitting remote_head versus our_head, I tried to find every use of the remote head and pick the appropriate variable, but I think I just missed this one. I gave the code another once-over and didn't see any other spots that needed fixing. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html