Re: [PATCH v2] bisect reset: Allow resetting to any commit, not just a branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 13 Oct 2009, Christian Couder wrote:
> +       1) git rev-parse --quiet --verify "$1^{commit}" > /dev/null ||
> +               die "'$1' does not seem to point to a valid commit"
> 
> It would give a better error message when "git rev-parse" fails instead of:
> 
> fatal: Needed a single revision
> 
> and it would not print the SHA1 from "$1^{commit}" when "git rev-parse" 
> succeeds.

Oh, oops, I somehow lost the > /dev/null in my version.

But as for the ‘git rev-parse’ error being confusing, why don’t we fix 
‘git rev-parse’ instead?

Anders
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]