Johannes Sixt <j.sixt@xxxxxxxxxxxxx> wrote:
> Shawn O. Pearce schrieb:
> > diff --git a/http-backend.c b/http-backend.c
>
> #include "run-command.h" is missing here because you added it already in
> patch 10/16 unnecessarily.
>
> > + if (start_command(&cld))
> > + die_errno("Cannot start %s", argv[0]);
> > ...
> > + if (finish_command(&cld))
> > + die("%s terminated with error", argv[0]);
>
> start_command and finish_command already write an error message for you
> that includes argv[0] and errno. You can just exit(1) here.
Whoops on both; thanks for the catch.
--
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html