Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > +valid_ref_normalized 'heads/foo' 'heads/foo' > +valid_ref_normalized 'refs///heads/foo' 'refs/heads/foo' > +invalid_ref_normalized 'foo' > +invalid_ref_normalized 'heads/foo/../bar' > +invalid_ref_normalized 'heads/./foo' > +invalid_ref_normalized 'heads\foo' What about '/refs/heads/foo'? Shouldn't that drop the leading /? I actually had someone enter that into Gerrit Code Review once, exposing a bug I have yet to fix that permits that as a valid branch name. *sigh* FWIW, I think this is heading in the right direction. Rather than teaching the UIs how clean up a name, give us a tool to do the normalization and validation, and let us call it when we get user input. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html