Re: [PATCH 1/2] t/test-lib.sh: support Korn shell by converting GIT_EXIT_OK to GIT_EXIT_CODE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 10, 2009 at 08:53:00AM -0400, Ben Walton wrote:

> > According to the autoconf docs this bug is also present in the Solaris
> > /bin/sh (and autoconf generated scripts use some elaborated workaround).
> 
> Solaris' /bin/sh shouldn't be used for anything but forking a decent
> shell, imo.  It was brought to my attention recently that the test
> suite for mercurial on solaris was failing the git tests.  The
> mercurial folks initially thought this was a git on solaris bug.

Yes, that is the attitude we take towards /bin/sh on Solaris. Most
people running git on Solaris (or other broken-shell platforms) point
SHELL_PATH to bash. I think the point of Brandon's patch is to let them
use a native shell.

So while /bin/sh is broken, the question is whether the alternate native
shell is broken enough to use or not.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]