Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> writes: > In the MSVC section of the Makefile, BASIC_CFLAGS is set to a > value which contains the string "-DWIN32-D_CONSOLE". This results > in a (single) malformed -Define being passed to the compiler. > At least on my cygwin installation, the msvc compiler seems to > ignore this parameter, without issuing an error or warning, and > results in the WIN32 and _CONSOLE macros being undefined. This > breaks the build. > > In order to fix the build, we simply insert a space between the > two -Define parameters, "-DWIN32" and "-D_CONSOLE", as originally > intended. > > Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> Thanks; that's quite a detailed description to explain why -DFOO-DBAR is bad when -DFOO -DBAR was wanted ;-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html