Sverre Rabbelier <srabbelier@xxxxxxxxx> wrote: > On Thu, Oct 8, 2009 at 08:49, Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: > > Shawn, last time I heard of this issue, it was stuck in your review queue. > > Correct, am waiting for Shawn's decision on whether to drop options > and replace them with additional features or not. Uh. Wow, it has been a while. IIRC my problem with options was we weren't enforcing them, and yet they were necessary for a successful import, e.g. import-marks or export-marks. A minor error could cause a successful looking import that is wrong due to the marks being messed up, or not saved out. So I was leaning towards making these features, but then they aren't necessarily compatible with the other fast-import tools. Which led me to a stalemate, and I forgot about the thread. Dammit. We should run this past the fast-import list but I think we want to declare features for import-marks and export-marks: feature import-marks=in.marks feature export-marks=out.marks and define these as paths to local files which store a VCS specific formatted mapping of fast-import mark numbers to VCS labels. Other options that are clearly git should be declared as: option git max-pack-size=2048 with the meaning of option being declared something like: If the parsing VCS name appears as the first argument, the parsing VCS must recognize and support the supplied option, and if not recognized or not supported must abort parsing altogether. If the parsing VCS name is not the first argument, it must entirely ignore the option command and not try to process its contents. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html