Brandon Casey wrote:
> Johannes Sixt wrote:
>> Brandon Casey schrieb:
>>> diff --git a/perl/Makefile.PL b/perl/Makefile.PL
>>> index 320253e..0b9deca 100644
>>> --- a/perl/Makefile.PL
>>> +++ b/perl/Makefile.PL
>>> @@ -5,6 +5,14 @@ sub MY::postamble {
>>> instlibdir:
>>> @echo '$(INSTALLSITELIB)'
>>>
>>> +ifneq (,$(DESTDIR))
>>> +ifeq (0,$(shell expr '$(MM_VERSION)' '>' 6.10))
>> I don't think the test works as intended, because 6.2 *is* greater than
>> 6.10 (aka 6.1).
>
> Hmm... I think you're right.
I think we're safe. Looks like the MakeMaker folks have always used two
digits for the minor number. So version 6.2 was written like 6.02.
Here's their repo:
git://github.com/schwern/extutils-makemaker.git
git log -p -- lib/ExtUtils/MakeMaker.pm | grep -- '$VERSION = ' | less
I didn't search exhaustively, but I think all of 6.X has two digit minor
numbers, which means all versions should compare correctly since 5.X will
always compare less than 6.X and 7.X will be greater, etc.
-brandon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html